FeaturesAttribute instead of individual feature attributes to match 3.x #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lock9
reviewed
Dec 11, 2019
|
Yes it's covered by a unit test. |
|
I'm ok with this change. Any reason for it still be in draft mode? |
From the original description: "Note, this PR is in draft waiting for #154 to be merged" |
erikzhang
reviewed
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
When I did #148, I forgot that the master branch has already created a FeaturesAttribute in #129. This PR updates the master-2.x branch NEON + smart contract framework to us a FeaturesAttribute like master branch.
~Note, this PR is in draft waiting for #154 to be merged ~